refactor "super dev compile" into "super compile" and "super db compile" #5366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit reparents the "super dev compile" command under the top-level "super" command and creates a parallel command "super db compile". This makes it much clearer as to when you are compiling a query for a lake vs a file system. We also changed the compile commands to take a single query argument instead of concatenating multiple arguments. Also, the command options are a little different: you now say "-dag" if you want the DAG output and get the AST output otherwise. There were some inconsitencies in how commands were parented so we added charm.NoRun() and fixed up the command hierarchy linkages. The invariant should now be that every internal command properly appears in the command hierarchy and NoRun() is invoked by the Run() method of an interior command to give proper help. The command-line help has also been updated.
mccanne
changed the title
nwt
reviewed
Oct 25, 2024
nwt
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit reparents the "super dev compile" command under the top-level "super" command and creates a parallel command "super db compile". This makes it much clearer as to when you are compiling a query for a lake vs a file system.
We also changed the compile commands to take a single query argument instead of concatenating multiple arguments. Also, the command options are a little different: you now say "-dag" if you want the DAG output and get the AST output otherwise.
There were some inconsitencies in how commands were parented so we added charm.NoRun() and fixed up the command hierarchy linkages. The invariant should now be that every internal command properly appears in the command hierarchy and NoRun() is invoked by the Run() method of an interior command to give proper help.
The command-line help has also been updated.